Commit Graph

593 Commits

Author SHA1 Message Date
Don HO
0f936707a2 [EU-FOSSA] Fix a security issue: RCE via unsanitized command line in "Open containing folder"
Summary of the Issue:
A remote code execution (RCE) vulnerability was found when a user opens a crafted containing folder in the command line. Code execution is possible by injecting a & followed by system commands into the name of the folder.

Steps to reproduce:
Download the attached archive on Windows: unzip_me.zip (F404758)
Unzip it and navigate into it
Open the txt file inside with Notepad++
Go to File -> Open containing folder -> cmd

Impact statement:
Successful exploitation of this vulnerability would allow an attacker to remotely execute arbitrary commands on the victim's computer.
2019-01-14 20:20:19 +01:00
Don HO
fd32585c14 List plugins in alphabetical order in Plugins Admin dialog 2019-01-14 20:02:47 +01:00
Don HO
70dee50dc7 Notepad++ 7.6.2 release Gilet Jaune Edition 2019-01-01 02:46:17 +01:00
Don HO
6eabece7ad Make Plugin Admin excluded from Windows XP because wingup doesn't work
under XP
2018-12-22 18:47:27 +01:00
Jon Bockhorst
4f24f81eb8 Add new feature: double click splitter resets panes to equal size
Close #5118
2018-12-20 09:51:42 +01:00
Don HO
15ef9bd052 Change nppPluginList.dll installation locaion
From %LOCALAPPDATA%\Ntepad++\plugins\Config\ to %PROGRAMDATA%\Ntepad++\plugins\Config\
2018-12-06 02:31:39 +01:00
Don HO
775d204ef9 Change loading plugin list location
Loading plugin list location is changed from %LOCALAPPDATA%\Notepad++\plugins\Config\ to
%PROGRAMDATA%\Notepad++\plugins\Config\

Enhance API NPPM_GETPLUGINSCONFIGDIR
2018-12-04 13:38:25 +01:00
0017031
d7507013e0 Enhance pluginsAdmin.h
use _TCHAR and _istdigit() to avoid wchar/char mismatch, and possible undefined behavior.
https://en.cppreference.com/w/cpp/string/byte/isdigit

Close #5067
2018-12-03 02:11:30 +01:00
Rajendra Singh
6e4f591bd1 Fix typo and remove unecessery files
Close #5071
2018-12-02 18:36:48 +01:00
Don HO
5df59ba2fc Add Pig latin language in installer 2018-11-28 02:56:02 +01:00
Don HO
78a0f57ed1 Make Plugins Admin translatable 2018-11-27 13:12:56 +01:00
Don HO
1ef92c6cce Fix a "Frenglish" issue. 2018-11-14 00:42:14 +01:00
Rajendra Singh
fd52450d16 Fixed memory leaks
Close #4945
2018-11-12 22:56:28 +01:00
Don HO
0abde25440 Clean up GUI in Plugins Admin 2018-11-12 02:21:21 +01:00
Rajendra Singh
94cf9d53ca Fix tool tip in document switcher showing the old name issue (after being renamed).
Fix #4910, close #4936
2018-11-10 13:53:53 +01:00
Rajendra Singh
b9b3faf307 Fix crash issue due to Unix style path input in Open file dialog.
This issue occurs when "Use New Style Dialog" setting is not used .
Ctrl+O, then type D:/*.log and hit Enter.

Fix #4946, close #4986
2018-11-10 12:15:08 +01:00
Don HO
8dea25feb5 Refactoring for optimizing/simplifying the code for getting plugin root path 2018-11-07 22:51:27 +01:00
Don HO
ee763ca0ad Change Plugins Admin installation behaviour
Old installation behaviour is loading installed plugins without restart Notepad++, which could make some plugins loading uncomplete.
New behaviour use the same implementation of plugin updating, witch quit notepad++ for plugin installation then restart Notepad++.
2018-11-01 18:42:35 +01:00
Don HO
ab8b5dc7a0 Shift the post installation (checking if the plugin is deployed correctely) responsability to WinGup
For the sake of retro-compatibility, change the way of plugin packaging:
1. The plugin DLL file should be placed at the root level of the ZIP file. It has to be the only DLL file on this level.
2. The root level of the ZIP file can also contain additional files and folders which will be copied to the users harddisk as well.
3. Everything what gets copied from the ZIP file will be stored under <Npp-installation-folder>\plugins\<plugin-name>.
2018-10-29 20:21:15 +01:00
Don HO
b01a396668 Remove SHA-256 hash checking from Plugins Admin
Pass hash to check to WinGup. WinGup will verify sha-256 hash of zip package for the plugin installation and update.
2018-10-27 15:41:12 +02:00
Don HO
c531a4d42a Send NPPN_READY notification to loaded plugins after their installation by Plugin Admin 2018-10-25 20:48:36 +02:00
Don HO
ef5d07771a Fix checking plugin crash issue due to plugin packaging error. 2018-10-25 03:34:49 +02:00
Don HO
519fecbb82 Add SHA-256 implementation and use sha-256 instead of md5 in Plugin Admin 2018-10-24 09:45:35 +02:00
Wurstbrot
c6e1a95098 Fix Tab non-responding after dragging bug
Short problem description:
Drag/drop a tab with the mouse to another position,
then all other tabs can't be activated with clicking anymore.

Also a missing include was added, that prevented compilation

Fix #4885, close #4886
2018-10-02 20:18:11 +02:00
Don HO
f0d130bbc5 Make plugin installer threadable. 2018-09-29 17:12:19 +02:00
Don HO
b662bcf5ae Add checking MD5 ability in Plugin Admin
Check MD5 after installing to prevent from MITMA
2018-09-27 09:56:58 +02:00
Don HO
6fb78db414 Fix a passing argument to wingup bug for Plugin Admin. 2018-09-24 02:25:33 +02:00
Don HO
da49749438 Define the plugin-list's path for Plugin Admin
It will be in plugins/Config/
2018-09-21 20:16:30 +02:00
Don HO
bfff12fd9c Add the load capacity after installing the plugins in Plugin Admin. 2018-09-20 09:24:11 +02:00
Don HO
6510889ba0 Add version management for Plugins update in Plugin Admin 2018-09-19 09:21:23 +02:00
Don HO
71dd261a50 Plugin Admin: Change the way to remove & update plugin
uninstall: tell user to restart Notepad++ - Gup.exe remove all - clean in batch - relaunch Notepad++
gup.exe -clean "appPath2Launch" "dest_folder" "fold1" "a fold2" "fold3"
gup.exe -clean "c:\npp\notepad++.exe" "c:\temp\" "toto" "ti ti" "tata"

update:    tell user to restart Notepad++ - Gup.exe download - remove all in directory - unzip/clean in batch - relaunch Notepad++
gup.exe -unzip -clean  "appPath2Launch" "dest_folder" "toto http://toto" "titi http://titi" "tata http://tata"
gup.exe -unzip -clean "c:\npp\notepad++.exe" c:\temp\ "toto http://toto" "ti et ti http://titi" "tata http://tata"

Install:   GUp.exe download - create directory - unzip: one by one, no relaunch
gup.exe -unzipTo c:\donho\notepad++\plugins "https://github.com/npp-plugins/mimetools/releases/download/v2.1/mimetools.v2.1.zip"
2018-09-13 23:07:22 +02:00
Magnus Österlund
f92d5e69ad Update Swedish localization
Close #4777
2018-09-02 17:14:20 +02:00
Don HO
3325da03a0 Fix a plugin installation problem
Add a new plugins loadding behaviour:
if it's not doLocalConf mode, then plugins can be loadded from "AppData\Local\Notepad++\plugins\", without presence of "allowAppDataPlugins.xml".
2018-08-19 18:04:16 +02:00
Don HO
f3c17e9886 Fix Plugin Admin installing plugins issues.
Fix Plugin Admin installing plugins bugs and check also wingup certificate before use it.
2018-08-12 15:21:21 +02:00
Don HO
e75cf910bd Add new brhaviour of checking Plugin List's certificate 2018-07-31 09:12:57 +02:00
Rajendra Singh
14b5e161cc Fixed crash issue by checking & unchecking "Disable extension column" in preferences dialog
Fix #4682, close #4684
2018-07-22 20:31:03 +02:00
Rajendra Singh
1c60f3f93e Fix "Explorer Here" from "Folder as Workspace" problem if folder name contains comma
Close #4686, Fix #4249
2018-07-22 10:50:44 +02:00
Don HO
43b2344b23 Fix Folder as Workspace not updating regression
This regression is due to commit 6890e94952 (#4257)

Fix #4644, fix #4379
2018-07-22 02:42:28 +02:00
Don HO
eb4edb50ef Plugin Admin - in progress 2018-07-19 02:03:17 +02:00
Don HO
587d3494c7 Fix the compiling failure on x64 build 2018-06-27 02:15:55 +02:00
Silent
08eb29e3d6 Force cpp standard const char pointer on string literals
const-ified all string literals to suppress warnings on gcc and allow /Zc:strictStrings to be used with Visual Studio

Fix #4146, close #4150
2018-06-25 00:06:26 +02:00
Don HO
593cf451fb Clean up 2018-06-24 01:16:01 +02:00
WoodsCheney
bac637ddfa Fix Open File Dialog error for a long path
Fix #4345
2018-06-24 00:42:03 +02:00
SinghRajenM
a83fa30de6 Fixed the macro deletion bug
Fix the issue that deleting a Macro doesn't remove it from the Run Macro multiple times dialog until restart

Fix #4526, close #4532
2018-06-21 09:57:04 +02:00
Silent
1482420fcb Fixed pointer truncations reported after removing /Wv:18
Close #4544
2018-06-21 02:36:28 +02:00
Derek
0c55b381da Fix a bug where the document map highlights incorrectly when the view is scrolled past the end of the file.
Fix #4579, close #4580
2018-06-21 02:28:51 +02:00
Don HO
32c1427c12 Add run process sync method & Plugin Admin's operations
Make Updater run sync for removing & restoring plugin info from & to the
plugin lists while the Plugin Admin's operation of installation, update and removal.
2018-06-19 09:39:42 +02:00
Don HO
2b7cd05093 Restore the needed functions 2018-06-13 14:02:49 +02:00
Don HO
c94319e863 Enhance installed list in Plugin Admin 2018-06-13 04:15:21 +02:00
Don HO
c30c0de0fc Refactoring Plugin Admin codes 2018-06-12 03:20:37 +02:00