Fierelier/notepad-plus-plus-legacy
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[EU-FOSSA] Fix stack overflow in extractSymbol function

Browse Source
This commit is contained in:
Don HO 2019-01-31 20:17:59 +01:00
parent c906af27b2
commit e691370e4f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PowerEditor/src/Notepad_plus.cpp
View File

@ -3952,9 +3952,10 @@ void Notepad_plus::showFunctionComp()
static generic_string extractSymbol(TCHAR firstChar, TCHAR secondChar, const TCHAR *str2extract) static generic_string extractSymbol(TCHAR firstChar, TCHAR secondChar, const TCHAR *str2extract)
{ {
bool found = false; bool found = false;
TCHAR extracted[128] = TEXT(""); const size_t extractedLen = 128;
TCHAR extracted[extractedLen] = {'\0'};
for (size_t i = 0, j = 0, len = lstrlen(str2extract) ; i < len ; ++i) for (size_t i = 0, j = 0, len = lstrlen(str2extract) ; i < len && j < extractedLen - 1; ++i)
{ {
if (found) if (found)
{ {
@ -3964,7 +3965,6 @@ static generic_string extractSymbol(TCHAR firstChar, TCHAR secondChar, const TCH
return generic_string(extracted); return generic_string(extracted);
} }
extracted[j++] = str2extract[i]; extracted[j++] = str2extract[i];
} }
else else
{ {